Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker release #1831

Merged
merged 14 commits into from
May 14, 2024
Merged

Fix docker release #1831

merged 14 commits into from
May 14, 2024

Conversation

gpmayorga
Copy link
Contributor

@gpmayorga gpmayorga commented May 8, 2024 •
edited
Loading

Description

  • Publishing docker container:
    • Push only to the Docker repository in Github when merging a PR, but not to Docker Hub
    • Publish to docker hub whenever a release is fully published (rather than created, pre-released, etc)
    • Push container to docker hub when creating a tag
    • Also possible to trigger a container from a branch manually as needed (publish only to GH repo)
  • Add comments to tags
  • Automatically comment at the end of a release with the docker tags published

@gpmayorga gpmayorga requested a review from wischli as a code owner May 8, 2024 16:55
@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.91%. Comparing base (8b20c3f) to head (1efc5a5).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
+ Coverage   46.87%   46.91%   +0.04%     
==========================================
  Files         165      165              
  Lines       12950    12950              
==========================================
+ Hits         6070     6076       +6     
+ Misses       6880     6874       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wischli
wischli approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the fix!

.github/workflows/build-docker.yml
${{ github.event_name != 'pull_request' && 'centrifugeio/centrifuge-chain' || ''}}
${{ (github.event_name == 'release' || (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/'))) && 'centrifugeio/centrifuge-chain' || ''}}
# TAGS:
# v.X.Y.Z when pushing a git tag (or a release)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
# v.X.Y.Z when pushing a git tag (or a release)
# vX.Y.Z when pushing a git tag (or a release)

.github/workflows/build-docker.yml
# TAGS:
# v.X.Y.Z when pushing a git tag (or a release)
# latest when triggered by a release
# PRXYZ when triggered from a PR (testing)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this, i.e., how can I trigger it from a PR?

@wischli wischli enabled auto-merge (squash) May 14, 2024 18:13
@wischli wischli merged commit a4b4df6 into main May 14, 2024
14 checks passed
gpmayorga added a commit that referenced this pull request May 17, 2024
@gpmayorga
Fix docker release (#1831)
96bee3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpmayorga @wischli